Bug parsing GCode comments - DDCSV2.1 - Standalone CNC Motion Controller - Digital Dream Technology support
View: 8764|Reply: 4
Print Previous Topic Next Topic

Bug parsing GCode comments

[Copy Link]

9

Threads

44

Posts

343

Credits

Intermediate Member

Rank: 3Rank: 3

Credits
343
Jump to the specified floor
Landlord
Posted at 2019-2-9 22:06:59 | Only Author Replies reward |Descending browser |Read mode
Hi all!

Not only, that the ddcsv hangs, if it parses too long comments, it seems to try to interprete them!
Why else should a line of GCode like

(Toolpaths: Planen1, Planen1 [4], Planen1 (3), Planen1 (2))

cause a syntax error?! If the "[4]" is deleted, all works perfect...

Two solutions to this problem:

1) Update your post processor to not generate this sort of comments
2) (More unlikely, since Digital Dream seems not to read this forum and react accordingly...): We get a bug fix...


Cheers

Josef

Reply

Use props Report

9

Threads

44

Posts

343

Credits

Intermediate Member

Rank: 3Rank: 3

Credits
343
Sofa
 Author| Posted at 2019-2-12 18:12:56 | Only Author
Hello again!

It may be I was wrong talking about a bug in the comment parsing.
When I tested it, I deleted the complete comment line and the G code worked after this.
I think the real Problem are the nested "()" in the comment. And this are due to an error of the post processor from Brian Right, which I use (after some modifications) for Fusion 360 (see http://www.brainright.com/Projects/CNCController/DDCSV11.cps).

There the function "writeComment" is coded as

function writeComment(text) {
  text = text.replace('(', '[').replace(')', ']');
  writeln("(" + text + ")");
}

This code replaces only the first "(" and ")" in a comment, others are untouched.
I changed it to

function writeComment(text) {
  text = text.replace(/\(/g," ").replace(/\)/g," ");
  writeln("(" + text + ")");
}

using the global replacement of the JS-replace function. To be on the save side, I replaced the brackets with a space, not with "[" and "]".
Those, who use Brians Post Processor should change it...

Josef

Reply Support Opposition

Use props Report

9

Threads

44

Posts

343

Credits

Intermediate Member

Rank: 3Rank: 3

Credits
343
Bench
 Author| Posted at 2019-2-13 18:32:43 | Only Author
Hi all!

Just to inform you: I contacted Jay (not Brian, sorry Jay) directly and he already updated http://www.brainright.com/Projects/CNCController/DDCSV11.cps!

Josef
Reply Support Opposition

Use props Report

0

Threads

3

Posts

8

Credits

Newbie Member

Rank: 1

Credits
8
Floor
Posted at 2024-10-14 15:37:18 | Only Author
Reply Support Opposition

Use props Report

0

Threads

1

Posts

4

Credits

Newbie Member

Rank: 1

Credits
4
5#
Posted at 2024-10-16 21:25:33 | Only Author
Reply Support Opposition

Use props Report

You need to log in before you can reply Login | Register now

This forum Credits Rules

Shenzhen Digital Dream Numerical Technology Co., Ltd. support
Adress:507,A Building,Leibo Industry Zone,No. 22 Jinxiu East Road,Kengzi Street,Pingshan district,Shenzhen City,P.R. of China
Phone:13244704799
E-mail:info@ddcnc.com

TEL

0755-87654321

Wchat

Website designed by DigitalDream Technology Support
Quick Reply Back to top Back to list